Chromedriver takes arguments

[dancourse]

This topic branch allows dalek-browser-chrome to pass any arguments to the chromedriver.

• Removed _checkUserDefinedPorts
• Replaced it with _checkUserDefinedArgs
  • This checks for any arguments sent to the chrome driver, the ports and any normal arguments

Thanks,

DanC

ps. I'm new to contributing to public repos, so apologies if I've missed some etiquette or the code is a bit squiffy. But git versioning is Wibbly wobbly Timey wimey, so I can re-do it!

[asciidisco]

Thanks for helping out :) I´m confused, isn't this (nearly) the same as I merged (and published a month ago)? See: https://github.com/dalekjs/dalek-browser-chrome/pull/8

Or am I missing something here?

Cheers Sebastian

[dancourse]

Hi Sebastian,

Doh', I just tried it with the commit #8 and it worked how I wanted it. I hadn't found the option in the readme so I must have missed it! No need for this topic branch anymore and thanks for getting back to me.

I'm really enjoying Dalek after all the pain I've been through getting selenium web driver to even come close to working.

Thanks for your help,

DanC

[dancourse]

I'll Close this pull request as it's not needed anymore

[asciidisco]

Ahhh. I thought the PR in #8 added also something to the docs... It doesn't look so, will add it in the next days.