Travis Ci: This build should fail but exit with 0

vergissberlin commented 10 years ago

Environment

DalekJS version: DalekJS CLI Tools Version: 0.0.4, DalekJS local install: 0.0.8
Operating System: Linux, Travis CI
Running Browser: PhantomJS
OS: linux unknown 64bit
Browser Version: 1.9.7
What

✘ TEST - "Fail test" FAILED
0/1 assertions passed. Elapsed Time: 0.42 sec 
The command "dalek tests/failTest.js" exited with 0.

As you can see in the log file, the test is failed. However dalek returns the status 0. Therefore, in Travis CI lit the green light. The standard Unix exit code of "0" means the build passed; everything else is treated as failure.

Where

The Build: https://travis-ci.org/vergissberlin/dalekjs-travisci/builds/27998721

Idea

That might solve the problem:

process.exit(exitCode);

Thank you, André

asciidisco commented 10 years ago

Thanks for the detailed report. We will try to take care of this asap.

vergissberlin commented 9 years ago

Wohoo.Hopefully I understand one day enough of your code, to fix it by myself. ;-)

JGVB commented 6 years ago

+1 adding "| xcpretty --test --color" to the end of an xcode build causes this issue. Seems like this is a workaround: https://groups.google.com/forum/#!msg/travis-ci/JtC4WiCMA0w/9PduHO3FOT8J

dalekjs / dalek-cli