compatibility fixed - Githubissues

yanawaro commented 10 years ago

I'm using sauce driver with dalekjs v0.0.4 found some compatibility bugs with the current sauce labs service

change default viewport to false because it makes android and opera browsers to crash with error 10:08:26.034 WARN - Exception: Window handling not supported on Android
update platforms to have Windows 8.1
modify desiredCaps to use version instead and able to config screens.
not sure why using reduce to verify available platforms but it skips the first entry.
modify _generateLongName to read long names from Dalekfile.json
I'm using browser config in Dalekfile.json like this "chrome-mac": { "platform": "OS X 10.6", "screen-resolution": "1440x900", "browserName": "chrome", "actAs": "chrome", "longName": "Chrome OSX", "version": "35", },

asciidisco commented 10 years ago

Thanks for your findings & fixes, these are very welcome additions & fixes. Can you brake down your PR into multiple ones? So basically, do one for every bullet point? That would make it easier to cherry pick & merge, as well as comment & work on some of these.

Thank you :)

yanawaro commented 10 years ago

Already done as requested. I'm enjoying using dalek for a while and happy to contribute. Cheers! :+1:

asciidisco commented 10 years ago

Thanks for the changes. I need to fix something in the build script first, before I can pull it in.

marsch commented 10 years ago

ping

dalekjs / dalek-driver-sauce

compatibility fixed #4