dalekjs / dalek

[unmaintained] DalekJS Base framework
MIT License
695 stars 63 forks source link

Open() does not throw error on inaccessible or invalid URL #117

Open niallo opened 10 years ago

niallo commented 10 years ago

Browser tests should fail in obvious cases like your server isn't running or you aren't on the right network. My suggestion is to check that the browser receives a valid response from the server.

Example test case to repro:

module.exports = {
  'Open should fail for bad URL but it does not': function(test) {
    test.open('foobar://BADURL.example').done();
  }
};

Output:

screen shot 2014-07-08 at 4 29 31 pm

asciidisco commented 10 years ago

Good catch, we need to take care of that.

rodneyrehm commented 10 years ago

This issue has been raised before, see #25