dalekjs / dalek

[unmaintained] DalekJS Base framework
MIT License
695 stars 63 forks source link

primitive http auth workaround #149

Open mexican75 opened 9 years ago

asciidisco commented 9 years ago

Having this method is better than having none.

The thing is, that this is not cross browser compatible (I can live with that for now). Firefox for example (which is broken atm. anyway) can not deal with credentials given via URL. Which is correct, because it is not part of any web standard. This must be noted in the docblock section, so that it will find it´s way into the automatically generated API doc page (plus, the docBlock needs an @api annotation).

Please also see the comments I´ve made inline in your commit. If that gets fixed, I´m happy to get it in.

asciidisco commented 9 years ago

Any news?