Added greater than and lower than assertion methods to the css() assertion method

dalekjs / dalek

[unmaintained] DalekJS Base framework

MIT License

695 stars 63 forks source link

Added greater than and lower than assertion methods to the css() assertion method #39

Closed mdix closed 10 years ago

mdix commented 10 years ago

Hi Sebastian,

I badly needed to check if a css value is lower than a certain value, so I added that feature into dalek (I also added greater than, just to have both ways ready). The docblocks are updated. By reading them you should be able to understand my idea and set up working assertions.

I'd really appreciate if you would review my changes and merge my pull request. If there's anything I need to improve before you can merge the pull request, please let me know.

Kind regards Marc

asciidisco commented 10 years ago

Hi Marc,

thanks, this was a thing I always skipped because there have been other things that seemed more important. Your PR looks good; thanks for contributing :)

We are currently in the process of rewriting stuff in the core module, which will mangle your code a bit, but that shouldn't be a problem. So, expect this to Land in the BIG 0.1.0 release :)

Cheers Sebastian