search

dalekjs / dalek

[unmaintained] DalekJS Base framework
MIT License
695 stars 63 forks source link

log.message can only be seen in the console if you set logLevel to 4 #78

Closed vladsoroceanu closed 9 years ago

vladsoroceanu commented 10 years ago

Hi,

This seems to not be documented, but log.message doesn't work out of the box. You need to run your test like this "dalek your_test.js -l 4" or set logLevel to 4 in the Dalekfile.json to be able to see the messages.

asciidisco commented 10 years ago

Thanks for the addition. Needs to be added to the docs.

mdix commented 10 years ago

Hi @asciidisco,

should this really be documented? I'd suggest changing it. log.message should have output no matter what loglevel I'm in (except zero, that should suppress any output).

Best Marc

Edit: Would you mind checking that issue? It's related to this one: https://github.com/dalekjs/dalek/issues/66

asciidisco commented 10 years ago

Correct, seems like a duplicate & after thinking about it for a second, I think you are right. log.messageshould always show the output beginning at log level 1. I believe that this is more user friendly & prevents headaches ;)

mdix commented 10 years ago

Ok, great. I'll place a PQ soon.

Best Marc

asciidisco commented 10 years ago

Fixed with https://github.com/mdix/dalek-reporter-console/commit/2065c43c12478a2920e76308bb5ffc6c07cce5d5

Will test & close if it works.