dalekjs / dalek

[unmaintained] DalekJS Base framework
MIT License
695 stars 63 forks source link

Dalek action (e.g. type) does not cancel if element is not found #86

Open izocan opened 10 years ago

izocan commented 10 years ago

Hey I have a textfield like this:

<input id="name" class="ember-view ember-text-field form-control" placeholder="Required" maxlength="20" type="text" data-testid="textfieldTerminalId">

If I use the dalek action type:

.type('[data-testid="txtfieldTerminalId"]', '12345678')

So when misspelling the attribute value, dalekjs seems to be looking for this element forever and does not cancel the current action. (i assume the action commands have no timeout).

I need the actions which cannot be executed cancelled, due to the fact that I want to automate my tests and dont want my whole test set depend on every type action I use in my test code. Is there any workaround or release which considers this issue?

Versions: Win7 dalek-cli 0.0.4 dalekjs local install: 0.0.8

cheers izocan

asciidisco commented 10 years ago

I do not have a workaround for you, sorry. This is really a nasty bug, related to #2

izocan commented 10 years ago

-.- will you treat this issue in the next release? i can work with this error now, but in future the whole team will write tests and the whole stuff will move towards automation. (so it does now but we dont have much tests and things are easier to fix). Cheers

asciidisco commented 10 years ago

I will try, but I wouldn't rely on it. If you wan't I could assist you when trying to get rid of this one. You know, Open Source and stuff ;)

izocan commented 10 years ago

hehe :) by the way you wanted to send me some low-level bugs to fix. if this is a bug i can handle why not ;). This would be the first time contributing to OpenSource. I can check it after i have writteen my bachelors thesis. AND check your public email please if you can :) cheers

asciidisco commented 10 years ago

Hey,

please ping me, when you are done with your thesis, we can then check together which bugs are low hanging fruits for you to tackle.

izocan commented 10 years ago

hey dude. im finished with the thesis. I need an urgent fix for this issue. I need at least something like a timeout. So the test should progress. I already tried so many workarounds. They worked locally during setting up the testsuites. But now we use the tests productive for our nightly builds. And the workarounds seem not to work right and the tests never progress further.

Could you assist me while fixing this bug??

cheers izocan.

Tuurlijk commented 10 years ago

I would love to see this solved as well. It's a real dealbreaker for me. Since my test now 'hangs' when the page does not contain the expected elements (v 0.0.8).

asciidisco commented 10 years ago

We will tackle this in the "super shiny new major rewrite" version, which does not work at the moment but estimations are that we will release an early version in October.

Follow this repo to see the current status.