search

dalen / puppet-puppetdbquery

Query functions for PuppetDB
Apache License 2.0
198 stars 71 forks source link

Add hiera 5 backend #104

Closed edestecd closed 7 years ago

edestecd commented 7 years ago

This restores hiera functionality in puppet 4.10/hera 5

dalen commented 7 years ago

Thanks for the contribution, this seems nice. I'm away at a conference at the moment though, but will take a closer look once after that and get back to you.

edestecd commented 7 years ago

I did some clean up and added a sort option. Not sure if the sort should just be applied, but it seemed nice to make it optional...

mmerfort commented 7 years ago

What's the status for this PR? I would really like to use the hiera backend.

bastelfreak commented 7 years ago

Hi @dalen, can you take a look at this again?

pietervogelaar commented 7 years ago

+1 I really need this

pietervogelaar commented 7 years ago

When will this be merged?

pietervogelaar commented 7 years ago

I merged this to my own fork and I can confirm this works beautifully! Thanks a lot @edestecd !!

pietervogelaar commented 7 years ago

One addition, In my opinion sort should be default TRUE

dalen commented 7 years ago

Sorry about the huge delay on this :( Merging now and will release a new version soon.

I agree it would make sense to sort by default.

edestecd commented 7 years ago

I'm not opposed to sorting by default. I would just need notice, so I could change my hiera.