search

dalen / puppet-puppetdbquery

Query functions for PuppetDB
Apache License 2.0
198 stars 71 forks source link

CLI commands interfere with core PE-client tools functionaility #105

Closed MartyEwings closed 7 years ago

MartyEwings commented 7 years ago

Prior to the installation of this module in PE the following command is a valid nodes query using PE-Client-tools:

 puppet query 'nodes { certname = "pe-201721-master.puppetdebug.vlan" }'
[
  {
    "deactivated": null,
    "latest_report_hash": "bcfeeca5d49b90608df6cd9a25d86b1816cb839c",
    "facts_environment": "production",
    "cached_catalog_status": "not_used",
    "report_environment": "production",
    "latest_report_corrective_change": false,
    "catalog_environment": "production",
    "facts_timestamp": "2017-07-25T08:46:29.114Z",
    "latest_report_noop": false,
    "expired": null,
    "latest_report_noop_pending": false,
    "report_timestamp": "2017-07-25T08:46:33.361Z",
    "certname": "pe-201721-master.puppetdebug.vlan",
    "catalog_timestamp": "2017-07-25T08:46:34.336Z",
    "latest_report_status": "unchanged"
  }

Following the installation of this module, overlapping syntax breaks this core functionality:

puppet query 'nodes { certname = "pe-201721-master.puppetdebug.vlan" }'
Error: 'query' has no 'nodes { certname = "pe-201721-master.puppetdebug.vlan" }' action.  See `puppet help query`.
dalen commented 7 years ago

Good catch. I'll rename the command to puppetdbquery for the 3.0.0 release.