dalen / puppet-puppetexplorer

Puppet module for installing Puppet Explorer
29 stars 21 forks source link

Compability issues with puppetlabs/apt puppet module #33

Open murhum1 opened 6 years ago

murhum1 commented 6 years ago

I'm trying to install puppetexplorer through the puppet module, but I'm getting the following error:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Apt::Source[puppetexplorer]: has no parameter named 'include_src' (file: /etc/puppetlabs/code/environments/production/modules/puppetexplorer/manifests/init.pp, line: 168)

This issue stems from puppetlabs/apt module 2.0.0 update all the way from 2015 and the removal of include_src parameter. The manifest should be updated to reflect this change - I doubt many are using older versions of the apt module anymore.

jjuarez commented 5 years ago

I faced the same issue, but fortunately you can address this situation for now using a specific commit in your Puppetfile as a dirty workaround, doing something like that:

#mod 'spotify-puppetexplorer', '1.1.1'
mod 'spotify-puppetexplorer',
  :git    =>'https://github.com/dalen/puppet-puppetexplorer.git',
  :commit => '02c09de'

this commit is "younger" than the tag 1.1.1, which is the official version of the module published on the puppet forge, and solves the compatibility problem with the new versions of the puppetlabs-apt module, I tested this with the 6.1.1 and the 5.0.1 version of the apt module and it works pretty well

cabrinha commented 5 years ago

Please release a new version on the forge.