search

dalen / puppet-puppetexplorer

Puppet module for installing Puppet Explorer
29 stars 21 forks source link

Added webserver_class to manage different possible web servers #8

Closed alvagante closed 10 years ago

alvagante commented 10 years ago

This is added to allow users to override the default apache settings (the may want to use another webserver or a different apache module)

The default behaviour is not changed

(Such a change definitively increases the reusability of the module (for example, using nginx on a specific project, I cannot currently use this module AS IS without modifications).

alvagante commented 10 years ago

I forgot to move the 'include apache' line... updated PR

alvagante commented 10 years ago

The rationale behind such a change is better explained here: http://www.example42.com/2014/10/29/reusability-features-every-module-should-have/

dalen commented 10 years ago

Sorry for late review, but this looks good to me. merging.