search

dalenguyen / firebase-wordpress-plugin

A plugin that helps to integrate Firebase to WordPress
https://firebase-wordpress-docs.readthedocs.io
GNU General Public License v2.0
111 stars 31 forks source link

Documentation error #125

Closed cmbritten closed 4 years ago

cmbritten commented 4 years ago

Describe the bug Your sample documentation is very helpful thanks. However, in your sample code one of the 'single quotes' ['] registers instead as an apostrophe, throwing an error. It could be updated for clarity!

To Reproduce Steps to reproduce the behavior:

  1. Go to https://firebase-wordpress-docs.readthedocs.io/en/latest/developer/retrieve-data.html
  2. The code is in the sample code here:

// You can get the collectionName and documentName from the shortcode attribute const collectionName = 'users'; const documentName = ‘document-1'

It should be corrected to remove the apostrophe before document-1 and use single quote.

// You can get the collectionName and documentName from the shortcode attribute const collectionName = 'users'; const documentName ='document-1'

Thought this might help others using your docs! Thanks for the great plugin.

dalenguyen commented 4 years ago

Thank @chriswhystle, the typo is fixed.