daler / gffutils

GFF and GTF file manipulation and interconversion
http://daler.github.io/gffutils
MIT License
287 stars 78 forks source link

Fix bug multiple values for ID attribute are no longer permitted since v0.11 #219

Closed Juke34 closed 1 year ago

Juke34 commented 1 year ago

interfeatures creates list of IDs: concat list of ID to create uniq IDs because feature with multiple values for their ID are no longer permitted since v0.11

The solution I suggest is quite brute and apply only when creating interfeatures features. Multiple IDs should not arise in other occasion. GFF specification does not allow multiple IDs, only multiple Parents.

daler commented 1 year ago

Thanks! Merged this into the release candidate branch, will be bundling multiple changes in the next version.

daler commented 1 year ago

@Juke34 only upon merging did I realize the tests did not actually run here, and despite having the proper settings, I do not see anywhere to approve running the GH Actions as indicated in GH docs. In #221 though, the tests are failing. Can you take a look at those?

Juke34 commented 1 year ago

I addressed the issues via ##222.