search

daleroberts / itermplot

An awesome iTerm2 backend for Matplotlib, so you can plot directly in your terminal.
1.49k stars 51 forks source link

remove unpacked kwargs from FigureCanvasAgg.print_png per Matplotlib 3.3 changes #44

Closed absurd closed 3 years ago

absurd commented 3 years ago

Kwargs are still being applied via ItermplotCanvasMixin.before_print

Resolves #43

djnym commented 3 years ago

@daleroberts any chance this will be merged, and maybe the change I mentioned in https://github.com/daleroberts/itermplot/issues/33 could also be fixed and pushed to pypi? I like the tool and want to use it but I currently have to fix these manually after installing into a virtualenv.

daleroberts commented 3 years ago

Sure, will try to do this later today.

On 7 Jul 2021, at 08:25, Anthony Molinaro @.***> wrote:



@dalerobertshttps://github.com/daleroberts any chance this will be merged, and maybe the change I mentioned in #33https://github.com/daleroberts/itermplot/issues/33 could also be fixed and pushed to pypi? I like the tool and want to use it but I currently have to fix these manually after installing into a virtualenv.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/daleroberts/itermplot/pull/44#issuecomment-875123107, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEOGJBFGZMYCEHMHKWWNX3TWN7GNANCNFSM43WKGKJQ.

daleroberts commented 3 years ago

Thanks for the pull request

daleroberts commented 3 years ago

pip install itermplot==0.4

rfabbri commented 10 months ago

The README still has pip3 install itermplot in the install section even though the beginning of the file it mentions the correct pip install itermplot==0.5. Fixing that would help. Thanks!