[Android Bootcamp] Project 3: Instagram Client - Ready for Review

[daleroy]

My app is complete, please review./cc @codepathreview @codepath

[codepathreview]

Good job finishing all the stories. Some feedback after looking at the code -

• Good job putting a global helper method to retrieve the InstagramClient in Application class
• It's better to do any assignment of subviews to fields in onViewCreated. This is because the framework does an automatic null check for you to ensure that your Fragment's view hierarchy has been created and inflated (if using an XML layout file) properly.
• Good job updating the adapter by calling notifyDataSetChanged instead of creating a new adapter after fetching completes
• Good job creating Fragment.newInstance to set Fragment's argument bundle so that any initialized data is restored on fragment re-creation
• It's always a good idea to display an indeterminate or determinate progress bar to the user when potentially long running tasks are happening in the background, especially those that update views. See this guide on implementing a ProgressBarView.
• It is recommended to put integer dimension, sp, dp etc to 'dimens.xml'