Exclusions file variable

[LordMike]

Hi,

It seems to me that the variable in the exclusions file (https://github.com/dalgibbard/citrix_xenserver_patcher/blob/master/exclusions/XS65_excludes.py#L2) should be named ´exclusions, and notautoexclusions`.. Else the patcher script won't interpret it correctly.

[dalgibbard]

Not quite; see lines 803 to 813:

## Request, where necessary, that patches in the Exclusions file are removed.
if not exclusions == False:
    for namelabel in exclusions:
        listremoveexclude(namelabel)

# Load the AutoExcludes:
autoexclusions = getAutoExcludeList(autourl)
## Patches loaded in from the auto-exclude file to be removed from the list next:    
if not autoexclusions == False:
    for namelabel in autoexclusions:
        listremoveexclude(namelabel)

This way, we allow for the definition of both a manual file and the autofile, by defining and trimming the patchset list against the two separate lists.

ie.

• exclusions = Manual/User exclusions
• autoexclusions = Automatically loaded exclusions from github

Hope that helps!

[LordMike]

The reason I investigated this was that the exclusions weren't being loaded. But perhaps I misunderstood a file placement og argument somewhere.. I can investigate later if necessary.

[dalgibbard]

If you like; post your command line and any additional files you're trying to load, and I can assist?

[LordMike]

Ooh. From reading the code, I see that the auto exclusions are fetched from the internet.

I wanted to exclude a single update, since it didn't apply to my system (XS65E015 iirc), so I added it to the exclusions file I had downloaded (I fetched the entire repo locally).

As the update was not ignored, I had specified a file to be loaded using the switch, but to no help (as when specifying by switch it has to be the other variable name).. Hence my issue.

All solved :)

[dalgibbard]

Makes sense! If it helps; XS65E015 is also now excluded automatically :)

[dalgibbard]

Just went through the readme and this element isn't very clear. Will reopen this to update it.

[LordMike]

To be fair, I didn't read the Readme..

However, I don't know if it's because it wasn't there long ago ?.. I've been using this patcher since 6.0. :) Else. Shame on me.

Mvh. Michael

On Wed, Nov 4, 2015 at 8:03 AM, Darren Gibbard notifications@github.com wrote:

Reopened #44 https://github.com/dalgibbard/citrix_xenserver_patcher/issues/44.

— Reply to this email directly or view it on GitHub https://github.com/dalgibbard/citrix_xenserver_patcher/issues/44#event-454108783 .

[dalgibbard]

Documentation updated.