dalgibbard / citrix_xenserver_patcher

Auto / Manual Patching tool for Citrix XenServer Boxes
Do What The F*ck You Want To Public License
142 stars 45 forks source link

Already applied patches (checking) #6

Closed lucaspr closed 9 years ago

lucaspr commented 10 years ago

I installed all patches already using the command line, but when I run patcher.py it tells me to install patches (6.2 SP1 is the latest I believe).

Is the script checking already installed patches?

I must tell you I only installed SP1, which included all previous patches according to Citrix...

Fr3DBr commented 10 years ago

Strange, make sure you are using the second line as I show you, it must work.

Fr3DBr commented 10 years ago

Also I am using the default exclusions file, without any changes.

dsiminiuk commented 10 years ago

I tried it with the updated version and the original and I get the same result.

One more time...

dsiminiuk commented 10 years ago

line 237

patch_upload_verify_cmd = str(xecli) + str(' patch-list params=uuid uuid=') + str(uuid) + str(" --minimal")

Running...

[root@xs3 ~]# ./patcher.py -e ./XS62_exclusions.py
Error: Failed to obtain HOSTUUID from XE CLI

With the original line...

patch_upload_verify_cmd = str(xecli) + str(' patch-list hosts=') + str(host_uuid) + (' params=uuid uuid=') + str(uuid) + str(" --minimal")

Running...

./patcher_orignial.py  -e ./XS62_exclusions.py
Error: Failed to obtain HOSTUUID from XE CLI
dsiminiuk commented 10 years ago

I also tried again with the original exclusions file, same...

dalgibbard commented 10 years ago

Hi all, I just wanted to quickly say thanks for all the debugging and effort you've all put in to getting this back on track; unfortunately a lot of my work has deviated away from xenserver for the time being, but I do expect to be back on this at some point- just so much going on! If you have some recommended changes please feel free to create your own fork of the repo, apply the fixes, and then request a merge following the instructions under: https://help.github.com/articles/creating-a-pull-request

Thanks again!

Fr3DBr commented 10 years ago

@dsiminiuk seems there is a difference between what happens in my xen server and in yours, now why is that, trying to guess...

dsiminiuk commented 10 years ago

Is there a debug mode for the script (or for python in general) that might expose an issue?

lucaspr commented 10 years ago

Long time since I've opened up this thread. Too long, but i'm seeing the "Error: Failed to obtain HOSTUUID from XE CLI" too.

Answered my onw question about a pool error.. Thats not it. Then why are we getting there errors..

Backup to manual updating for these pending updates I guess..

dalgibbard commented 10 years ago

It's the most likely issue; none of the boxes I had at the start of this were in pools (and they still aren't!), so I had nothing to test against :)

dalgibbard commented 9 years ago

Long time no update; i've recently switched the method by which the Host UUID is obtained (pulling the host's name from /etc/sysconfig, which maps to the name-label parameter for xe host-list) - so this paired with the exclusions file should resolve the issues being discussed here.

Would anyone be willing to test and verify?

dsiminiuk commented 9 years ago

Crap, I just updated last weekend or I could try it. there was one patch 009. I'll try it next time a new patch is issued.

dalgibbard commented 9 years ago

Haha! no problem :) I'll close this for now anyway- and re-open if it's still an issue.