daliansky / XiaoMi-Pro-Hackintosh

XiaoMi NoteBook Pro Hackintosh
BSD Zero Clause License
2.62k stars 473 forks source link

Proper platform id for GPU #121

Closed Mateo1234454545 closed 5 years ago

Mateo1234454545 commented 5 years ago

I see you use 0x0591b platform id for Intel UHD620. is there any reason for not using 0x0591b ? Is there any advantage of using one over other ?

stevezhengshiqi commented 5 years ago

It is 0x59160000 actually... I wrote it in README. I believe I have briefly explained this question before. The reason to choose 5916 for UHD620 because it is recommended by main hackintosh masters. For example, in https://github.com/acidanthera/WhateverGreen/blob/master/WhateverGreen/kern_model.cpp, vit9696 wrote { 0x5917, 0x5916, "Intel UHD Graphics 620" },

, and also in https://github.com/RehabMan/OS-X-Clover-Laptop-Config/blob/master/hotpatch/SSDT-IGPU.dsl, Rehabman wrote // Kaby Lake-R/UHD620 0x5917, 0, Package() { "AAPL,ig-platform-id", Buffer() { 0x00, 0x00, 0x16, 0x59 },

stevezhengshiqi commented 5 years ago

For more information, you can go to https://www.tonymacx86.com/forums/mojave-laptop-support.196/ and ask for professional help.