search

dalibo / explain.dalibo.com

PEV2 Flask service. Visualizing and understanding PostgreSQL EXPLAIN plans made easy.
PostgreSQL License
44 stars 16 forks source link

Large plan content fails to be stored without obvious error #6

Closed danwakefield closed 2 years ago

danwakefield commented 2 years ago

When submitting planContent above the limit for LocalStorage (5 mb) it fails without any indication to the user.

E.g https://gist.github.com/steelbrain/e57e508278a79ea4397efba9872b2b17

An error is raised in the console

Screenshot 2022-04-30 at 15 37 20

It would be nice to catch the error and tell users that minimizing JSON input would help.

https://github.com/dalibo/explain.dalibo.com/blob/2f3c61adee821c2bdcdffbf6e5730df382fca5b4/app/static/js/index.js#L59

pgiraud commented 2 years ago

Thanks for the report. Related to https://github.com/dalibo/pev2/issues/481

pgiraud commented 2 years ago

Today, we deployed a new version. The plan are now automatically sent to server. The issue with the local storage being full should not happen anymore. Closing.