search

dalibo / pgsql-resource-agent

Simple Pacemaker OCF Agent for two PostgreSQL servers in streaming replication
Other
11 stars 4 forks source link

perl pgsqlms - Useless monitor call during promotion #12

Closed mrimbault closed 8 years ago

mrimbault commented 9 years ago

In sub pgsql_promote, after the promotion has succeeded, we force a "hard safe check" using pgsql_monitor and OCF_CHECK_LEVEL=10. At this point, we already had a return code from pgsql_monitor showing that the promotion succeeded, and OCF_CHECK_LEVEL is currently always configured to do a "hard" check (also cf. pgsql_monitor and _confirm_role todos). Thus, this new call to pgsql_monitor is useless, unless we adapt the way we use OCF_CHECK_LEVEL in other places.

mrimbault commented 8 years ago

Check levels removed in commit b6c1624