search

dalibo / pgtoolkit

Postgres Support from Python
https://pgtoolkit.rtfd.io/
PostgreSQL License
21 stars 9 forks source link

Only try to parse commented configuration entry with an = #101

Closed dlax closed 2 years ago

dlax commented 2 years ago

It seems not possible to distinguish a commented parameter without an = sign from a plain sentence, as shown in extra test case where the default header of postgresql.conf is inserted. Therefore, we only try to parse commented lines as commented parameters if there is an equal sign.

codecov-commenter commented 2 years ago

Codecov Report

Merging #101 (c6ca6ae) into master (00b4f57) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   98.46%   98.47%           
=======================================
  Files          10       10           
  Lines        1110     1112    +2     
=======================================
+ Hits         1093     1095    +2     
  Misses         17       17
Impacted Files Coverage Δ
pgtoolkit/conf.py 98.94% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00b4f57...c6ca6ae. Read the comment docs.

dlax commented 2 years ago

Hm, "RPM packages" checks in CI build the package using a tarball from pypi instead of using the git repository, so obviously the second fix has no effect until we release it...