search

dalibo / pgtoolkit

Postgres Support from Python
https://pgtoolkit.rtfd.io/
PostgreSQL License
21 stars 10 forks source link

Typing #47

Closed dlax closed 4 years ago

dlax commented 4 years ago

This adds type hints to the whole code base. Many small changes are introduced as before, mostly to help type checking. Also needed to disable the "nit-picky mode" of sphinx because some references now fail to be found despite being actually defined (I suspect a bug in sphinx, maybe https://github.com/sphinx-doc/sphinx/issues/7493 or https://github.com/sphinx-doc/sphinx/issues/7450).

codecov-commenter commented 4 years ago

Codecov Report

Merging #47 into master will decrease coverage by 0.35%. The diff coverage is 98.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   99.73%   99.38%   -0.36%     
==========================================
  Files           7        9       +2     
  Lines         746      808      +62     
==========================================
+ Hits          744      803      +59     
- Misses          2        5       +3
Flag Coverage Δ
#py26 ?
#py36 99.38% <98.85%> (-0.36%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pgtoolkit/_helpers.py 94.11% <87.50%> (-5.89%) :arrow_down:
pgtoolkit/conf.py 100.00% <100.00%> (ø)
pgtoolkit/errors.py 100.00% <100.00%> (ø)
pgtoolkit/hba.py 100.00% <100.00%> (ø)
pgtoolkit/log/__init__.py 100.00% <100.00%> (ø)
pgtoolkit/log/__main__.py 100.00% <100.00%> (ø)
pgtoolkit/log/parser.py 100.00% <100.00%> (ø)
pgtoolkit/pgpass.py 100.00% <100.00%> (ø)
pgtoolkit/service.py 97.53% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e70f2d...c8a4ad0. Read the comment docs.