search

dalibo / pgtoolkit

Postgres Support from Python
https://pgtoolkit.rtfd.io/
PostgreSQL License
21 stars 9 forks source link

Fix ordering of PassEntry w.r.t. to 'port' value type #83

Closed dlax closed 3 years ago

dlax commented 3 years ago

By previously return either an int or a string as 'port' value in PassEntry.as_tuple() we could get a TypeError when trying to compare str and int values in sort_key() method. We now convert the port field into a string int as_tuple().

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c75eab3). Click here to learn what that means. The diff coverage is 100.00%.

:exclamation: Current head 6ef1b16 differs from pull request most recent head 6958264. Consider uploading reports for the commit 6958264 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage          ?   98.51%           
=========================================
  Files             ?       10           
  Lines             ?     1077           
  Branches          ?        0           
=========================================
  Hits              ?     1061           
  Misses            ?       16           
  Partials          ?        0
Impacted Files Coverage Δ
pgtoolkit/pgpass.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c75eab3...6958264. Read the comment docs.