search

dalibo / pgtoolkit

Postgres Support from Python
https://pgtoolkit.rtfd.io/
PostgreSQL License
21 stars 9 forks source link

Avoid writing an empty passfile #99

Closed dlax closed 2 years ago

pgiraud commented 2 years ago

This looks good. However the first commit message is a bit weird. I think you messed up "we" and "when".

codecov-commenter commented 2 years ago

Codecov Report

Merging #99 (8150fcd) into master (befe32d) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          10       10           
  Lines        1105     1110    +5     
=======================================
+ Hits         1088     1093    +5     
  Misses         17       17
Impacted Files Coverage Δ
pgtoolkit/pgpass.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update befe32d...8150fcd. Read the comment docs.

dlax commented 2 years ago

However the first commit message is a bit weird. I think you messed up "we" and "when".

Indeed; fixed, thanks.