Add non regression tests

dalibo / pitrery

DEPRECATED. PostgreSQL Point In Time Recovery made easy

http://dalibo.github.io/pitrery/

Other

108 stars 31 forks source link

Add non regression tests #99

Open l00ptr opened 4 years ago

l00ptr commented 4 years ago

pitrery is a set of complex scripts. I think it could be nice to add some basic tests to make sure we don't regress. For me it's the first step before doing some advanced refactoring or adding some new features.

I think we can start by writing some basic tests based on bats and shellcheck - then see how to automate those tests

madtibo commented 4 years ago

Hello @l00ptr That would be a great contrib!
Look forward to work on it.

l00ptr commented 4 years ago

Two ideas to improve the quality of pitrery :

static code analysis (for that part we can use shellcheck)
Define advanced tests scenario

I think both can be done in parallel - shellcheck tests are easier to implement - it's more difficult for advanced scenario. First we need to define what we want to test - so i guess it could be nice to test pitrery actions on :

CentOS 7 and 8 - what about CentOS 6
Debian 9 and 10 Both with Postgres : 9.5 to 12

madtibo commented 4 years ago

As CentOS 6 is nearly in end of support (nov 2020), I would say CentOS 7 and 8, plus debian 9 and 10 are more than enough (especially for a start).

Testing with all PostgreSQL supported versions is a very good idea!

madtibo commented 3 years ago

We now have good test coverage for local usage of pitrery.

We will now work on CI tests for remote pitrery usage (with ssh and rsync).