search

dalibormesaric / PublishNotifier

Notify your team in Slack or Microsoft Teams when you Deploy a Web Project Using One-Click Publish from Visual Studio or you just publish to a folder.
https://marketplace.visualstudio.com/items?itemName=dalibormesaric.PublishNotifier
Other
5 stars 3 forks source link

Visual Studio freezes on publish #2

Open dylanvdmerwe opened 3 years ago

dylanvdmerwe commented 3 years ago

Installed product versions

Description

On publish with a project that has a PublishNotifier.json file configured:

1) On successful publish the Publish Notifier window appears. This is wrong as the solution already has a configuration file. 2) Pressing Publish freezes Visual Studio completely. You then need to close VS through task manager.

image

3) Why is the PublishNotifier.json file in a subdirectory, not on sln level?

image

Expected behavior

The popup should not be displayed once configured. Just perform the notification. Do not freeze Visual Studio.

dalibormesaric commented 3 years ago

1) There might be a time when you do not want to publish a notification, that's why it prompts every time. Initially I didn't think it would be a big deal since publish does not happen that often. 2) It should definitely not freeze visual studio, but this one will be tricky to reproduce. 3) Since you can only publish a project, json file lives next to it. Different projects might use different channels for notifications. Also, you can't put files on the solution level so that they show in Solution Explorer, they can be either under solution folders or projects. So maybe under Solution Items folder - but they I don't know how to separate notifications channels for different projects.

I can add a checkbox to ask if you should be prompted on every publish. Then you would have to edit the json file to enable dialog prompting again.

dylanvdmerwe commented 3 years ago

My first concern is to prevent VS from crashing. We have had to disable the extension for now,

dalibormesaric commented 3 years ago

I may have been able to recreate VS crash. I didn't really implement any error handling, so even if you had a whitespace instead of a valid url, extension would crash and made visual studio unresponsive.

Can you try with a CI build before I publish new version to the marketplace https://www.vsixgallery.com/extension/763d21f2-0b6e-49d1-ac3c-bd3a74e78566/ ?

alexmelville7 commented 3 years ago

It's still crashing with the CI build. The slack webhook URL is a valid URL with no whitespaces.

dalibormesaric commented 3 years ago

Changes from @alexmelville7 PR are now published to the marketplace https://marketplace.visualstudio.com/items?itemName=dalibormesaric.PublishNotifier

Let me know if this works now. Thanks a lot!