Default to 0 for required Attributes

dalinicus / homeassistant-acinfinity

AC Infinity integration for Home Assistant for UIS based controllers

MIT License

75 stars 4 forks source link

Default to 0 for required Attributes #53

Closed cole-maclean closed 6 months ago

cole-maclean commented 6 months ago

Required parameters needed defaults after firmware update, integration started working after this change.

dalinicus commented 6 months ago

My git client screwed up the merge, but I added some tests for your change. Did some spot manual testing and everything seems good 👍🏻

I'm wondering if this isn't related to the issues we were seeing with #39. There could be other fields that may need defaults added.

I'll push this out as version 1.4.2. Thanks for the contribution :)

cole-maclean commented 6 months ago

Oh I should have added tests, thanks for those! I'm not too sure if this is related to #39, the error I was getting back was a 400, and details were a javascript parsing error trying to convert Strings to Ints on value None. I went to reproduce the log but reverting the changes in this PR locally, the error didn't reproduce, so I wonder if this is only a bug on initial setup of the integration. Bit of a weird one!

Thanks again for all your work on this dalinicus!