search

dalinvip / cnn-lstm-bilstm-deepcnn-clstm-in-pytorch

In PyTorch Learing Neural Networks Likes CNN、BiLSTM
Apache License 2.0
1.22k stars 341 forks source link

`optim_momentum_value` for SDG in train_ALL_LSTM #3

Closed wayne-ss closed 5 years ago

wayne-ss commented 5 years ago

https://github.com/bamtercelboo/cnn-lstm-bilstm-deepcnn-clstm-in-pytorch/blob/1efb2be7868432f0264ad1124a4b9c0c959286f2/train_ALL_LSTM.py#L30-L33

I guess the momentum=args.momentum_value should be momentum=args.optim_momentum_value, as it is defined in:

https://github.com/bamtercelboo/cnn-lstm-bilstm-deepcnn-clstm-in-pytorch/blob/1efb2be7868432f0264ad1124a4b9c0c959286f2/Config/config.py#L279-L281

I would like to contribute/fix small changes like above in your repo? Is there a way I can help with (like pull requests, or slack group)?

dalinvip commented 5 years ago

thanks, I have fixed it