search

daliusd / ghlite.nvim

Neovim plugin to work GitHub PRs quickly.
MIT License
38 stars 1 forks source link

Switch <C-CR> to another map for compatibilty issues with windows users #1

Closed alanfzf closed 1 week ago

alanfzf commented 1 week ago

Hey there dude, Alan from reddit here, first of all, let me say well done, so far im loving this plugin, its minimalistic and adjusts to my workflow, its a blessing to have an easy way to review prs within nvim!

On the other side, i've noticed that the default mapping to send a comment on the pr window is mapped to <C-CR> this may be a bit of an issue for windows users, as this escape code is not sent by default on windows terminal, the defacto and most popular terminal on windows.

This behavior will make windows users think your plugin doesn't work at all, so i think it would be good, to map this key to something else? maybe like <localleader> + P?

daliusd commented 1 week ago

I will make this configurable.

daliusd commented 1 week ago

Check documentation - you can override keybindings now.

alanfzf commented 1 week ago

Thank you!