search

dallasrb / dallasrb-web

The Dallas Ruby Brigade Website
10 stars 14 forks source link

[Bug Fix] for issue 19 #20

Closed manusajith closed 11 years ago

manusajith commented 11 years ago

Fixing user authentication Added before_filter :authenticate_user!

manusajith commented 11 years ago

Fix 9aa817df07c9c1422ebc72ffb0b1687d96f19d5e for issue #21 also added

hkarthik commented 11 years ago

Thanks for the commits. Email is interesting in that you made it read-only, because it can essentially never be changed. We pull it from GitHub during signup when we create the profile but we don't read it from there again.

I can envision someone wanting to change their email (if we ever start using emails inside the app) but not being able to with that last commit. Thoughts?

hkarthik commented 11 years ago

I just read your other issue. I think we can pull this in but we need to deal with the re-sync issue too. Thanks for finding this stuff!