Closed esmale closed 11 years ago
hkarthik
commented
11 years ago The CSS and HTML here is beginning to depart from Bootstrap a little bit. I used the Media List component that they described here: http://twitter.github.io/bootstrap/components.html#media
Take a look at that and let me know what you think. If you still think it's worth departing to make better use of space then I am okay with it.
hkarthik
commented
11 years ago Another thing I noted is that the team page doesn't load now. I think the partial being moved broke that. If you can fix that would be great. Thanks @esmale !
esmale
commented
11 years ago Fixed the broken team page, and added some tests so that I'll (hopefully) not break it again in the future.
I see where you're coming from with the Media component, but I disagree with it being particularly applicable here. The examples provided by the documentation ("various types of components (like blog comments, Tweets, etc)") have an inherent chronological order to them, so a 1-column vertical layout makes the most sense.
Our profile cards don't really have that implicit order to them. You don't have to read the 'first' one to understand what the 'last' one is saying. Personally, I think the departure is warranted.
hkarthik
commented
11 years ago Okay awesome. Yeah I think your changes sound good then.
I think if the profiles page is structured this way (essentially in two columns) it makes better use of the space on the page. There is still room for people to write a little blurb about themselves, but it feels like the amount of vertical scrolling on the page is reduced.
I also moved the shared/_profile partial into the profiles directory instead, and am rendering it with render partial. I like the syntax, since it is literally what we want ('render this partial') but am curious what you guys think of it.