search

dallasrb / dallasrb-web

The Dallas Ruby Brigade Website
10 stars 14 forks source link

Timecop and simple_form gems; Profile validation #42

Closed esmale closed 10 years ago

esmale commented 11 years ago

Updated Timecop gem to 0.6.2 (0.6.1 was breaking for me) Added simple_form gem Added validation for Profile homepage field to include protocol and allow it to be empty, and associated tests Updated Profile edit view to use simple_form for easy display of Profile errors

esmale commented 11 years ago

Started with what @scrozier did and fleshed it out a bit, including tests for the Profile.homepage field.

mattr- commented 11 years ago

Seems ok to me. I think I'll let @hkarthik have the final say though. :smiley:

hkarthik commented 11 years ago

The build failing is concerning. Looks like the debugger gem is the culprit. @esmale do you want to try removing it and seeing if that fixes it? We don't really need the debugger gem honestly.

esmale commented 11 years ago

So now it's failing because it can't find version 0.6.2 of timecop. I reverted the Gemfile to specify 0.6.1 of the gem, but the build is still looking for 0.6.2.

mattr- commented 11 years ago

0.6.2 appears to have been yanked and 0.6.2.2 is the latest version. A bundle update timecop should do the trick.

esmale commented 11 years ago

Grrr...TravisCI is failing because it is still looking for 0.6.2.

hkarthik commented 11 years ago

@esmale do you want to move these commits to a branch off dallasrb-web master? Your commit rights should allow you to create a branch in this repo. Then more of us can tackle this without having to issue PRs to your branch for fixes we find.

esmale commented 10 years ago

Starting fresh to get these changes in, so closing this pull request.