Closed esmale closed 10 years ago
Started with what @scrozier did and fleshed it out a bit, including tests for the Profile.homepage field.
Seems ok to me. I think I'll let @hkarthik have the final say though. :smiley:
The build failing is concerning. Looks like the debugger gem is the culprit. @esmale do you want to try removing it and seeing if that fixes it? We don't really need the debugger gem honestly.
So now it's failing because it can't find version 0.6.2 of timecop. I reverted the Gemfile to specify 0.6.1 of the gem, but the build is still looking for 0.6.2.
0.6.2 appears to have been yanked and 0.6.2.2 is the latest version. A
bundle update timecop
should do the trick.
Grrr...TravisCI is failing because it is still looking for 0.6.2.
@esmale do you want to move these commits to a branch off dallasrb-web master? Your commit rights should allow you to create a branch in this repo. Then more of us can tackle this without having to issue PRs to your branch for fixes we find.
Starting fresh to get these changes in, so closing this pull request.
Updated Timecop gem to 0.6.2 (0.6.1 was breaking for me) Added simple_form gem Added validation for Profile homepage field to include protocol and allow it to be empty, and associated tests Updated Profile edit view to use simple_form for easy display of Profile errors