search

dallasrb / dallasrb-web

The Dallas Ruby Brigade Website
10 stars 14 forks source link

Updated Readme for setup and some code cleanup #7

Closed esmale closed 11 years ago

esmale commented 11 years ago

Updated setup instructions for setting up application.yml and github integration

Replaced Profile class methods with scopes

Update Members page to 1) not display the 'Register with Github' widget if User is already logged in 2) display a 'No approved Users found' message if there are no User records to display

hkarthik commented 11 years ago

Everything else looks good, just remove the scopes and I'll be glad to pull this in. Thanks @esmale!

esmale commented 11 years ago

That was an interesting read. Starting to re-think my opinion on scopes now.

In any event, the scopes have been reverted back to class methods.

Is there anything else on your todo list that I can help out with? And also, when will you (or Mark) start 'approving' people that have registered on the site? ;-)

hkarthik commented 11 years ago

Thanks for that revert. As soon as I get a build notification passing I'll try to merge your PR in.

I'm planning on creating a bunch of open github issues and using that to solicit some help.

Something is broken in the approval/profile process so I need to work that out. I'll tackle that sometime this week.

Thanks again for the PR!