dallassoftwaredevelopers / DSDsite

An Open Source Website For Dallas Software Developers Meetup Group
http://www.dallassoftwaredevelopers.org
MIT License
37 stars 40 forks source link

chore: Add images to cards on homepage with borders (WEB-33) #71

Closed TheDThompsonDev closed 7 months ago

TheDThompsonDev commented 8 months ago

The images have been added to the assets folder. We need the images being passed into the cards. This should follow a similar pattern as to how the text is currently being passed. You will have to make sure you add the type as well for typescript.

image

Use the Figma file in the readme as a source of truth for this.

Steps to contribute. NEVER COMMIT TO MAIN. NEVER COMMIT TO MAIN. It should always be on your own branch and that branch name should match the issue. Ensure that you are addressing the correct issue. Each issue will be listed as something like a chore, fix, bug, etc. Your commit message MUST start with one of these tags that correspond with your issue. Followed by your commit message and your commit message must end with the branch name, for example (WEB-1)

An example commit message would look like this: chore: create contributing guidelines (WEB-8)

Commit messages should not be written in an action or present tense. It also should not mention tasks unrelated to the issue "Creating Contributing Guidelines and will work on next task" is not what we would want to see as a commit message.

After a pull request is approved, the branch should be deleted once merged.

UsmanCanCode commented 8 months ago

I can work on this