search

daltoniam / Starscream

Websockets in swift for iOS and OSX
Apache License 2.0
8.22k stars 1.19k forks source link

Client side authentication #991

Open dimitrovvlado opened 7 months ago

dimitrovvlado commented 7 months ago

What do you want to happen?

Add client side authentication (mTLS)

What happens now?

As per the following PR https://github.com/daltoniam/Starscream/pull/481, there used to be an option to setup client side authentication (mTLS), but it has mysteriously disappeared between https://github.com/daltoniam/Starscream/commit/a2ed45c0b2f996cb8c335c4f270ecc68c3bd4c0f and https://github.com/daltoniam/Starscream/commit/c946f5c68b1e6e5721a8113c8323faf0308298cf. I couldn't find an alternative, is this an oversight?

gregorosaurus commented 3 months ago

Also wanting to know what happened to client side TLS auth. Hope it comes back! :(

2h4u commented 2 weeks ago

Are there any updates on this topic? I need mTLS support as well.

2h4u commented 2 weeks ago

There is already a PR which aims to re-add it: https://github.com/daltoniam/Starscream/pull/871

gregorosaurus commented 2 weeks ago

I ended up removing the library and switched to use the built-is Swift web socket class. It supports URL Session Delegates which allow you to use mTLS.