search

daltonmaag / ubuntu

Other
31 stars 5 forks source link

Several OTLOffsetOverflowErrors #21

Closed madig closed 6 years ago

madig commented 6 years ago

When compiling the UFOs, many fonts will print a warning like

INFO:fontTools.ttLib.tables.otBase:Attempting to fix OTLOffsetOverflowError ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 1, 'ItemName:', 'Coverage', 'ItemIndex:', None)
INFO:fontTools.ttLib.tables.otBase:Attempting to fix OTLOffsetOverflowError ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 1, 'ItemName:', 'Coverage', 'ItemIndex:', None)
INFO:fontTools.ttLib.tables.otBase:Attempting to fix OTLOffsetOverflowError ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 2, 'ItemName:', None, 'ItemIndex:', None)
INFO:fontTools.ttLib.tables.otBase:Attempting to fix OTLOffsetOverflowError ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 1, 'ItemName:', 'ClassDef1', 'ItemIndex:', None)
INFO:fontTools.ttLib.tables.otBase:Attempting to fix OTLOffsetOverflowError ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 1, 'ItemName:', 'ClassDef1', 'ItemIndex:', None)
INFO:fontTools.ttLib.tables.otBase:Attempting to fix OTLOffsetOverflowError ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 3, 'ItemName:', 'ClassDef1', 'ItemIndex:', None)
INFO:fontTools.ttLib.tables.otBase:Attempting to fix OTLOffsetOverflowError ('GPOS', 'LookupIndex:', 0, 'SubTableIndex:', 3, 'ItemName:', 'ClassDef1', 'ItemIndex:', None)

Is this something that needs to be fixed?

anthrotype commented 6 years ago

no, that's the way it is. It's the huge GPOS kerning. fonttools does the right thing :tm: and fixes the offset overflows by upgrading overflowing lookups to extension lookups

anthrotype commented 6 years ago

you see the verbosity level is INFO, not WARNING nor ERROR

madig commented 6 years ago

Okay, just wondering :)

anthrotype commented 6 years ago

no, that's a totally reasonable thing to ask! in fact, fonttools may not be doing that as efficiently as the font developer manually adding useExtension directives to the feature files

see https://github.com/fonttools/fonttools/issues/1105