daltonmaag / ubuntu

Other
31 stars 5 forks source link

Run Fontbakery tests at build time #36

Open sladen opened 6 years ago

sladen commented 6 years ago

Fontbakery is a set of tests used for validation before on-boarding new releases into Google Fonts.

Ubuntu needs to pass this for normal releases.

Therefore these need to be integrated as validation at build/post-build time.

madig commented 6 years ago

In a quick test run, fontbakery complained about the presence of the kern table 😁

moyogo commented 6 years ago

Browsers don't use the kern table since there is GPOS kerning. However some applications like PowerPoint only use the kern table. So for web fonts it doesn't make sense to have both kern table and GPOS kerning.

On Sat, 16 Dec 2017, 14:57 Nikolaus Waxweiler, notifications@github.com wrote:

In a quick test run, fontbakery complained about the presence of the kern table 😁

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/daltonmaag/ubuntu/issues/36#issuecomment-352188490, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1ao9HdMSNVxoQ5ha-Zlac9Kqp3nupFks5tA9psgaJpZM4RBUBZ .

madig commented 6 years ago

Okay :) Not sure if one can upload fonts with that "error" then (the current fonts on GF have it anyway). Ideally we only have one binary build for everything?

Here's the fontbakery output for R: Validationrun-R.txt. Interestingly, FontVal seems to have checks for hdmx, VDMX and LTSH. If these tables turn out to be necessary, I can maybe salvage the code.

moyogo commented 6 years ago

I'd say fontbakery needs to allow the kern table, exceptionally is OK.

moyogo commented 6 years ago

Or we produce two sets of fonts.

anthrotype commented 6 years ago

Two sets of fonts is better, the kern table is just dead weight for a web font

davelab6 commented 6 years ago

Google Fonts ingests fonts made for download and use as desktops, and does all web font optimizations in the serving pipeline (using libre libraries that anyone can replicate.)

madig commented 6 years ago

Oh, that's neat. So why does it complain about e.g. the kern table in fontbakery, or put differently, does the error matter if the optimization is done anyway?

davelab6 commented 6 years ago

TTFs intended for desktop users (and thus the ones intended for GF) should have both KERN and GPOS tables.

madig commented 6 years ago

But fontbakery check-googlefonts ... complains about the kern table.

davelab6 commented 6 years ago

Its a bug.

felipesanches commented 6 years ago

It's a fixed bug ;-)

Thanks @sladen for having reported it!

felipesanches commented 6 years ago

https://github.com/felipesanches/fontbakery/commit/ec36a1b9a5329e487085340728b0795a145245be