daltonmaag / ubuntu

Other
31 stars 5 forks source link

Modify name table to pass more fontbakery checks #42

Open madig opened 6 years ago

madig commented 6 years ago
  1. Delete openTypeNameDescription as it was deemed too long.
  2. Change openTypeNameDesigner and openTypeNameManufacturer to "Dalton Maag Limited", as that is what the vendor id DAMA resolves to officially.
  3. Insert openTypeNameLicense and openTypeNameLicenseURL.

More modifications are necessary: should openTypeNameLicense spell out the entire license text?

sladen commented 6 years ago

Can we split this into what is useful for reaching baseline parity vs. what is useful for making FontBakery happier?

madig commented 6 years ago

The only real baseline change would be to remove the description.

The other diffs to baseline are: 1) No Mac name table in the UFO 2) Version and UniqueID are different, intentionally so if I see this correctly (https://github.com/daltonmaag/ubuntu/pull/1):

--- /tmp/font1/Ubuntu-R.ttx 2017-12-28 21:42:45.814749674 +0100
+++ /tmp/font2/Ubuntu-R.ttx 2017-12-28 21:42:46.542746366 +0100
@@ -2,40 +2,4 @@

   <name>
-    <namerecord nameID="0" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Copyright 2011 Canonical Ltd.  Licensed under the Ubuntu Font Licence 1.0
-    </namerecord>
-    <namerecord nameID="1" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Ubuntu
-    </namerecord>
-    <namerecord nameID="2" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Regular
-    </namerecord>
-    <namerecord nameID="3" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      0.83;DAMA;Ubuntu-Regular
-    </namerecord>
-    <namerecord nameID="4" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Ubuntu Regular
-    </namerecord>
-    <namerecord nameID="5" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      0.83
-    </namerecord>
-    <namerecord nameID="6" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Ubuntu-Regular
-    </namerecord>
-    <namerecord nameID="7" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Ubuntu and Canonical are registered trademarks of Canonical Ltd.
-    </namerecord>
-    <namerecord nameID="8" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Dalton Maag Ltd
-    </namerecord>
-    <namerecord nameID="9" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Dalton Maag Ltd
-    </namerecord>
-    <namerecord nameID="11" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      http://www.daltonmaag.com/
-    </namerecord>
-    <namerecord nameID="12" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      http://www.daltonmaag.com/
-    </namerecord>
     <namerecord nameID="0" platformID="3" platEncID="1" langID="0x409">
       Copyright 2011 Canonical Ltd.  Licensed under the Ubuntu Font Licence 1.0
@@ -48,5 +12,5 @@
     </namerecord>
     <namerecord nameID="3" platformID="3" platEncID="1" langID="0x409">
-      0.83;DAMA;Ubuntu-Regular
+      Ubuntu Regular Version 0.83
     </namerecord>
     <namerecord nameID="4" platformID="3" platEncID="1" langID="0x409">
@@ -54,5 +18,5 @@
     </namerecord>
     <namerecord nameID="5" platformID="3" platEncID="1" langID="0x409">
-      0.83
+      Version 0.83
     </namerecord>
     <namerecord nameID="6" platformID="3" platEncID="1" langID="0x409">
sladen commented 6 years ago

The openTypeNameDescription was already already commited in: