daltonmenezes / aura-theme

✨ A beautiful dark theme for your favorite apps.
MIT License
3.32k stars 155 forks source link

feat(port): support Waybar #179

Closed Hendrikto closed 1 year ago

Hendrikto commented 1 year ago

Description

This PR adds a port for Waybar.

Questions

  1. Should the config file be included? Should we link to it?
  2. Waybar does not seem to have a logo. I used the profile picture of its author as a placeholder. How should we handle this?

Assets

  1. The project does not have a logo (see question 2 above).
  2. whole screen just the bar

Checklist

Hendrikto commented 1 year ago

RE: Question 1

I don't know how familiar you are with Waybar. A full configuration consists of two files: config and style.css.

I only included the style.css file in this PR, because config is not strictly related to theming. The style.css file does not directly depend on config or vice versa. They just go well together.

However, we might at least want to link to an example config, such that the example screenshot can easily be reproduced.

daltonmenezes commented 1 year ago

Hi @Hendrikto , about your questions:

  1. You can link the example config file and the necessary instructions for the people who never made this, what do you think about it?
  2. I made a simple icon for Waybar for us: waybar-icon
daltonmenezes commented 1 year ago

@Hendrikto for the banner image you can use this one: Group 1

Hendrikto commented 1 year ago

Should I use

const previewURL = `https://github.com/${info.author.username}/assets/blob/master/images/${info.slug}/aura-waybar-preview.png?raw=true`

?

daltonmenezes commented 1 year ago

Should I use

const previewURL = `https://github.com/${info.author.username}/assets/blob/master/images/${info.slug}/aura-waybar-preview.png?raw=true`

?

This one, please:

https://user-images.githubusercontent.com/1149845/223881256-6726819c-5ce5-4c84-a84b-0a4f70993b96.png
Hendrikto commented 1 year ago

Everything should be done now :+1:

daltonmenezes commented 1 year ago

Well done @Hendrikto , thanks 💜