Fix bracket and tag scope highlighting for Sublime Text

daltonmenezes / aura-theme

✨ A beautiful dark theme for your favorite apps.

MIT License

3.21k stars 152 forks source link

Fix bracket and tag scope highlighting for Sublime Text #95

Closed Hendrikto closed 2 years ago

Hendrikto commented 2 years ago

Description

Fixes issues #94 and #96.

Checklist

[x] PR description included
[x] I've read the documents
[x] I've created or commented in an issue related to this port asking to work on it
[x] I know I shouldn't change any files in the packages folder manually

daltonmenezes commented 2 years ago

Hi @Hendrikto , could you please provide a screenshot showing the result? It's important for quick feedback. 💜

Hendrikto commented 2 years ago

Hi @Hendrikto , could you please provide a screenshot showing the result? It's important for quick feedback. :purple_heart:

Sure thing.

It is a bit hard to see, due to #96, but in the after image you can see that the parentheses are now underlined

Before:

After:

daltonmenezes commented 2 years ago

@Hendrikto perfect, thanks. How about to try it to accent1 or accent2?

Hendrikto commented 2 years ago

How about to try it to accent1 or accent2?

Both work well. Personally, I think I prefer accent2.

accent1:

accent2:

Edit: Note that this PR is only about making the indicators visible at all. #96 deals with the color.

daltonmenezes commented 2 years ago

@Hendrikto we can go with the accent2 if it's perfect for you. Also, this PR can have the change from accent17 to accent2 without no problem, as this change makes it more visible. 😄

Hendrikto commented 2 years ago

Also fixes #96 now.

daltonmenezes commented 2 years ago

Thank you so much for your contribution @Hendrikto 💜