daltonpurnell / apv

Automatically exported from code.google.com/p/apv
GNU General Public License v3.0
0 stars 0 forks source link

Fling won't let you reach the bottom of the pdf. #74

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open pdf
2. Scroll to near the bottom
3. Try and fling to the bottom

What is the expected output? What do you see instead?
Should scroll to the bottom and stop.  Scrolls slowly to somewhere just short 
of the bottom or snaps to somewhere just above the bottom.

Please provide any additional information below.
cx.hell.android.lib.pagesview.PagesView.java lines 1164 and 1165 incorrectly 
pass in this.width to getLowerBound(), it should be this.height.

int miny = this.height/2 + getLowerBound(this.width, marginY,
    getCurrentDocumentHeight());
int maxy = this.height/2 + getUpperBound(this.width, marginY,
    getCurrentDocumentHeight()); 

Should be:

int miny = this.height/2 + getLowerBound(this.height, marginY,
    getCurrentDocumentHeight());
int maxy = this.height/2 + getUpperBound(this.height, marginY,
    getCurrentDocumentHeight()); 

Original issue reported on code.google.com by jonathan...@gmail.com on 23 Oct 2011 at 2:19

GoogleCodeExporter commented 8 years ago
Damn it, just saw this post after I poster mine,
I have same issue, Nexus S

Original comment by Youse...@gmail.com on 10 Nov 2011 at 4:37

GoogleCodeExporter commented 8 years ago
Thanks, fix committed for dev11.

Original comment by arpruss on 4 Dec 2011 at 8:20