search

dalyIsaac / Whim

Pluggable dynamic window manager for Windows🏗️🪟
https://dalyisaac.github.io/Whim/
MIT License
184 stars 10 forks source link

Fix monthly checks for UpdaterPlugin #1065

Closed dalyIsaac closed 3 weeks ago

dalyIsaac commented 3 weeks ago

Previously, using a monthly check for updates would cause an integer overflow.

This was because of the maximum dueDate in the Timer class. This has been resolved by triggering the event daily and verify whether a check can occur on that date.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (1063-provide-yaml-config-by-default@3b91392). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Whim.Updater/UpdaterPlugin.cs 7.69% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1063-provide-yaml-config-by-default #1065 +/- ## ====================================================================== Coverage ? 80.56% ====================================================================== Files ? 283 Lines ? 12408 Branches ? 1432 ====================================================================== Hits ? 9997 Misses ? 2226 Partials ? 185 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.