Running sequencer on Windows unsuccessfull - Githubissues

dalya / Sequencer

An algorithm that detects one-dimensional sequences in complex datasets

MIT License

118 stars 21 forks source link

Running sequencer on Windows unsuccessfull #4

Open RandomCraftr opened 2 years ago

RandomCraftr commented 2 years ago

Hello,

attempt at running sequencer on windows raise multiple issues.

scalelist not being passed by default, it is computed at instanciation starting line 94 - sequencer.py. Array is then numy.int32 even on x64 Windows with x64 Python installed. Than assertion line 180 fails.
scale_list being explicitly passed through argument as numpy.int64 casted array, line 76 fails because of scale_list != None

Proposition for resolution:

when scale_list is computed, explicitly specify type it will be asserted against : l103 - self.scale_list = numpy.array(scale_list, dtype=numpy.int64)
when scale_list is tested whether being passed as argument or not, prefer "is not None" instead of != None"

RandomCraftr commented 1 year ago

Same kid of issue at line 902 of sequencer_.py. ordering_bfs = numpy.array(ordering_bfs).astype(numpy.int) is proposed to be replaced by: ordering_bfs = numpy.array(ordering_bfs).astype(numpy.int64)