search

dalya / Sequencer

An algorithm that detects one-dimensional sequences in complex datasets
MIT License
118 stars 21 forks source link

Correct some type check which was platform dependant. #5

Open RandomCraftr opened 2 years ago

RandomCraftr commented 2 years ago

Regarding ticket , I propose the minimal change: every time type is checked against numpy.int64, I add a or statement to accept if numpy.int32.

(It appears that even python on Windows 64bits platform encode numpy.array by default in 32 bits.)

dawndown commented 9 months ago

when I run the python code in Windows system, it will report an error: AssertionError: scale values must all be integers. But when I run the code in Linux system, it works!!! So I suggest making some adjustments that the code could run in Windows platform. Thanks.

mmarcatili commented 4 months ago

I report the same issue - "AssertionError: scale must all be integers" - on Windows. I am unable to try this on Linux (I don't have a Linux system).

mmarcatili commented 4 months ago

I have now tried the modification suggested by RandomCraftr and can confirm that it seems to fix the problem on Windows.

dalya commented 4 months ago

Hi everyone, the pip install leads to an older version of the code. If instead you download the repository from github, you should be able to run the code without errors.

mmarcatili commented 4 months ago

Thanks Dalya, I can confirm I installed from github using the directions here. I did also try a pip install and yes, it had other issues beyond those mentioned here.

dalya commented 4 months ago

I see now. I will go over the code and add the option of numpy.int32 in places where an integer is required. It would take me a few days to get to that. Thank you for letting me know.