Inject assembly attributes on compilation as well as git

damageboy / daemaged.gitinfoplanter

Plant Git Information into .NET Assemblies using Mono.Cecil

MIT License

11 stars 2 forks source link

Inject assembly attributes on compilation as well as git #3

Closed roji closed 10 years ago

roji commented 10 years ago

How about also injecting attributes with:

Which user compiled
On which machine
In which directory

etc.

The injection of these attributes could be optional...

roji commented 10 years ago

You're doing conditional injection of these for .NET 4.5 only, which is good, but you require users to pass --platform in order to know which .NET we're on. Deduce this from the DLL you're injecting instead...

damageboy commented 10 years ago

Good idea, I'll get to it.

roji commented 10 years ago

Here's a way to detect .NET 4.5 on a DLL:

[assembly: TargetFramework(".NETFramework,Version=v4.5", FrameworkDisplayName = ".NET Framework 4.5")]

damageboy commented 10 years ago

I'm splitting the platform detection to another Issue