damavis / airflow-pentaho-plugin

Pentaho plugin for Apache Airflow - Orquestate pentaho transformations and jobs from Airflow
Apache License 2.0
38 stars 17 forks source link

Advanced statuses handling. #5

Closed IM-SIM closed 3 years ago

IM-SIM commented 3 years ago

Added statuses: "Finished (with errors)", "Stopped (with errors)" (Otherwise, it waits endlessly)

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 3 years ago

Codecov Report

Merging #5 (2424b61) into master (460dea1) will decrease coverage by 0.32%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   80.54%   80.21%   -0.33%     
==========================================
  Files           9        9              
  Lines         370      374       +4     
==========================================
+ Hits          298      300       +2     
- Misses         72       74       +2     
Impacted Files Coverage Δ
airflow_pentaho/operators/carte.py 89.13% <71.42%> (-1.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 460dea1...2424b61. Read the comment docs.

piffall commented 3 years ago

Hi @IM-SIM,

LGTM. I've just checked all possible statuses here, and it seems that all are getting covered. https://github.com/pentaho/pentaho-kettle/blob/master/engine/src/main/java/org/pentaho/di/trans/Trans.java

I'll merge and release this fix ASAP.