damdafayton / to-do-list

app["web"]: "to-do list application"

https://damdafayton.github.io/to-do-list/dist

1 stars 0 forks source link

peer-to-peer code reviews #7

Open Elerqsousy opened 2 years ago

Elerqsousy commented 2 years ago

Testing with jest, part(1)

Amazing job on testing and mocking. I believe the function is depending on many variables, which can be avoided by breaking the tested function into smaller modules. and testing them one by one by isolating the function (if possible) and testing each function separately.

https://github.com/damdafayton/to-do-list/blob/7d1264c81edd9047bb7a81acdc7d887be6e1fb02/src/modules/addTask.js#L3-L17

Tufahel commented 2 years ago

@damdafayton, You have done a great job with adding, deleting, and updating items. Congrats. There are some issues that you can consider:

The input segment is taking blank input in the to-do list. You can consider avoiding blank lists.
Consider adding a delete button for each of the to-dos keeping the deleting functionalities. Thank you. Happy Coding :+1: