search

damellis / ESP

The Example-based Sensor Predictions (ESP) system applies machine learning to real-time sensor data.
BSD 3-Clause "New" or "Revised" License
224 stars 52 forks source link

Sync GRT HEAD? #279

Open nebgnahz opened 8 years ago

nebgnahz commented 8 years ago

I am under the impression that we take a snapshot of GRT and use it for most of the development.

However, given the PR and other changes that has been made in GRT, should we consider syncing our GRT?

Also this might be helpful if we are hosting the workshop together (avoid different GRT APIs).

The argument for not syncing with the master is that we are using GRT 0.0.1 release.

I've seen a couple significant changes in HEAD:

  1. There are some type changes that we will need to address if we sync. E.g. MatrixDouble is no longer available and it's now MatrixFloat. If you dig more about what's the float, you will see typedef double Float.
  2. VectorFloat is different from vector<double> so it's not directly cast-able.
damellis commented 8 years ago

I think it's probably a good idea. Any thoughts on how we should go about it?

nebgnahz commented 8 years ago

I think it would be helpful to still use your forks: syncing that to the master and then update our submodule. Then fix any compilation and API changes (this could take a while...).