search

damellis / attiny

ATtiny microcontroller support for the Arduino IDE
722 stars 227 forks source link

Add analogReference Functionality #47

Open Merrr opened 10 years ago

Merrr commented 10 years ago

Full functionality for analogReference:

damellis commented 10 years ago

Adding analogReference() support would be great (if it doesn't work right now). But this patch looks like it's against the old "pre1" ATtiny files that included their own version of the Arduino core. The current ATtiny support (in master for 1.0.x and ide-1.5.x) relies on the standard core file in the Arduino distribution. Do you want to look into supporting analogReference() for those branches (i.e. using the standard Arduino core)?

mischnic commented 8 years ago

It seems like it isn't possible putting modified Arduino.h and wiring_analog.c files somewhere to override the ones supplied by Arduino. Would it be okay to create a whole new core for this?

damellis commented 8 years ago

I don't think this is worth including a whole new core for. I think it's important to avoid doing that because it gets out of sync with the main Arduino core and it's easy to fall behind on changes / bug fixes. If there are things that need to be changed in the core, we should try to get the Arduino repository updated. Do you want to open a pull request there?

mischnic commented 8 years ago

Here's the pull request: https://github.com/arduino/Arduino/pull/5300

mischnic commented 8 years ago

The pull request just got merged, the fix will be in Arduino 1.6.12 . @damellis This pull request can be closed.